Skip to content

[BillingTrust] Add Microsoft.BillingTrust TypeSpec API spec (2026-03-17-preview)#43896

Merged
abhimrnandan-ms merged 23 commits into
mainfrom
users/abmohanr/billingtrustrp-public-spec
Jul 1, 2026
Merged

[BillingTrust] Add Microsoft.BillingTrust TypeSpec API spec (2026-03-17-preview)#43896
abhimrnandan-ms merged 23 commits into
mainfrom
users/abmohanr/billingtrustrp-public-spec

Conversation

@abhimrnandan-ms

@abhimrnandan-ms abhimrnandan-ms commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

New ARM resource provider: Microsoft.BillingTrust

  • API version: 2026-03-17-preview (preview)
  • Resources: Assessments (CRUD + list), Rules (CRUD + list)
  • TypeSpec source with generated OpenAPI
  • Provides Assessment and Rule resources used to evaluate trust attributes (such as education-domain qualification and business verification) of a billing account

Previously merged in azure-rest-api-specs-pr PR #28678.

Release Plan

  • Release Plan: #34897
  • Service Tree ID: 403a7ada-b47f-4ac7-ad33-cd76e1fa7614

Packages

  • Azure.ResourceManager.BillingTrust (.NET)
  • azure-mgmt-billingtrust (Python)
  • azure-resourcemanager-billingtrust (Java)
  • @azure/arm-billingtrust (JavaScript)
  • armbillingtrust (Go)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.BillingTrust-BillingTrust
TypeSpec Microsoft.BillingTrust
Go sdk/resourcemanager/billingtrust/armbillingtrust
Python azure-mgmt-billingtrust
JavaScript @azure/arm-billing-trust
Java com.azure.resourcemanager:azure-resourcemanager-billing-trust

Comment generated by After APIView workflow run.

@abhimrnandan-ms

abhimrnandan-ms commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

The Microsoft.BillingTrust namespace was merged to RPSaaSMaster in azure-rest-api-specs-pr via PR 28678 (ARM review signed off). However, the CI-RpaaSRPNotInPrivateRepo check does not appear to detect it.

Private repo PR link : https://github.com/Azure/azure-rest-api-specs-pr/pull/28678
Could someone from the ARM review team help investigate and unblock this PR?

@abhimrnandan-ms

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@github-actions github-actions Bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview CI-RpaaSRPNotInPrivateRepo labels Jun 16, 2026
abhi3047office and others added 2 commits June 16, 2026 15:32
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@abhimrnandan-ms abhimrnandan-ms added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jun 16, 2026
@abhimrnandan-ms

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree [company="Microsoft"]

@abhimrnandan-ms abhimrnandan-ms force-pushed the users/abmohanr/billingtrustrp-public-spec branch from a27d1d4 to 7039a86 Compare June 17, 2026 17:32
@abhimrnandan-ms

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@abhimrnandan-ms abhimrnandan-ms enabled auto-merge (squash) June 17, 2026 17:34
abhi3047office and others added 3 commits June 17, 2026 13:07
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@abhimrnandan-ms abhimrnandan-ms force-pushed the users/abmohanr/billingtrustrp-public-spec branch from 7039a86 to 238f3b5 Compare June 17, 2026 20:07
@abhimrnandan-ms

abhimrnandan-ms commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@gary-x-li
This issue was raised and resolved during the ARM review of the private repo PR (azure-rest-api-specs-pr#28678), which was merged with ARMSignedOff. Here is the context:

1. BillingRP owns GDPR handling. BillingTrust is a read-only projection of the billing account's sold-to data — not the system of record. GDPR cleanup (right-to-erasure, etc.) is handled by BillingRP, and BillingTrust reflects/propagates changes and cleanup automatically.

2. PII tagging is already in place. The SoldTo model @doc carries an explicit PII classification block, and every PII-bearing field has a per-field "PII — postal address" or "PII — contact" marker in its documentation.

3. ARG indexing is disabled on the rules resource type. We set resourceGraphConfiguration.enabled: false on assessments/rules so the PII fields never reach the ARG cache. The parent assessments RT (which does not carry PII) keeps ARG indexing enabled.

4. expandCustomerData query parameter is not feasible for this resource type. Reads are served by MetaRP from its tracked-resources cache — the RP is not invoked on the read path. Implementing an expand pattern would require registering ResourceRead extensions and changing the read architecture. Given that ARG indexing is disabled on the rules RT, disabling ARG is the proportionate fix per the architect's guidance.

The soldTo, registrationNumber, and taxIds fields are all @visibility(Lifecycle.Read) (read-only, server-managed) — they are populated from the billing account at rule creation time and cannot be supplied or modified by end users.

@github-actions github-actions Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 18, 2026
@abhimrnandan-ms

abhimrnandan-ms commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

@gary-x-li — Friendly follow-up. The ARG002 finding on SoldTo was already reviewed and accepted during the private repo ARM review (PR #28678, merged with ARMSignedOff). The mitigation is disabling ARG indexing on the rules resource type (resourceGraphConfiguration.enabled: false). Full justification is in my earlier comment above.

Could you please review and sign off? We're targeting a Public Preview release this month. Thank you!

@gary-x-li gary-x-li added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Approved-Suppression and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 19, 2026
@msyyc

msyyc commented Jun 30, 2026

Copy link
Copy Markdown
Member

python fails for a known issue and I have sought help in teams channel

@msyyc

msyyc commented Jul 1, 2026

Copy link
Copy Markdown
Member

python check pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMModelingAutoSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version new-rp-namespace PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants